Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kurtosis clean -a chokes on Docker zombie processes #959

Closed
mieubrisse opened this issue Jul 21, 2023 · 0 comments · Fixed by #965
Closed

kurtosis clean -a chokes on Docker zombie processes #959

mieubrisse opened this issue Jul 21, 2023 · 0 comments · Fixed by #965
Labels
bug Something isn't working critical Critical bug or feature painful Painful bug

Comments

@mieubrisse
Copy link
Member

mieubrisse commented Jul 21, 2023 •
edited

What's your CLI version?

0.80.13

Description & steps to reproduce

For some reason, certain containers fail to die normally and are marked as zombies. We've seen this with NEAR, and also in HugoByte/DIVE#53 (comment) (even though the DIVE CLI is correctly using the "all" flag: https://github.com/HugoByte/DIVE/blob/main/cli/common/types.go#L201 )

In these cases, kurtosis clean -a fails to kill them initially, but usually a second clean will kill them.

Desired behavior

kurtosis clean should always clean, regardless of zombie process or not. This might be looking for the "zombie process" message and attempting a retry, or maybe it's figuring out what's causing the thing to be a zombie process in the first place. Regardless, we should handle this for the user.

What is the severity of this bug?

Painful; this is causing significant friction in my workflow.
@mieubrisse mieubrisse added the bug Something isn't working label Jul 21, 2023
@github-actions github-actions bot added the painful Painful bug label Jul 21, 2023
@mieubrisse mieubrisse added critical Critical bug or feature and removed painful Painful bug labels Jul 21, 2023
@github-actions github-actions bot added the painful Painful bug label Jul 21, 2023
@mieubrisse mieubrisse mentioned this issue Jul 21, 2023
Closed
@gbouv gbouv mentioned this issue Jul 24, 2023
Merged
gbouv pushed a commit that referenced this issue Jul 25, 2023
fix: Run user service containers in --init mode for Docker (#965)
b8989a8 
## Description:
Hopefully fixes #959 
It also adds a retry mechanism on RemoveContainer when this specific
error is hit

## Is this change user facing?
NO
<!-- If yes, please add the "user facing" label to the PR -->
<!-- If yes, don't forget to include docs changes where relevant -->

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
@CyrusVorwald CyrusVorwald mentioned this issue Jul 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working critical Critical bug or feature painful Painful bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Run user service containers in --init mode for Docker kurtosis-tech/kurtosis
1 participant
@mieubrisse