fix: Run user service containers in --init mode for Docker #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
changed the title
gbouv
force-pushed
the
gbouv/run-user-service-containers-in-init-mode
branch
from
6781a7f
to
ee5cfb4
Compare
leoporoli
approved these changes
Jul 24, 2023
victorcolombo
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.15](0.80.14...0.80.15) (2023-07-25) ### Features * Implement V0 of docker import ([#968](#968)) ([6f8d90d](6f8d90d)) ### Bug Fixes * Run user service containers in --init mode for Docker ([#965](#965)) ([b8989a8](b8989a8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hopefully fixes #959
It also adds a retry mechanism on RemoveContainer when this specific error is hit
Is this change user facing?
NO
References (if applicable):