-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add instructions on how to use idempotent runs in our docs #1286
Open
leeederek
wants to merge
4
commits into
main
Choose a base branch
from
derek/add-idempotent-runs-to-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Got some additional tidying up to do actually - will re-request a review once I add a code example |
auto-merge was automatically disabled
October 13, 2023 13:09
Merge queue setting changed
@leeederek can we merge or close this PR? |
Not yet - this is on my TODO list for adding code examples. Is there something that this PR is blocking? |
@galenmarchetti i was going to add code examples but lets just do that in a separate PR |
auto-merge was automatically disabled
November 11, 2023 01:04
Merge queue setting changed
galenmarchetti
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We've enabled
idempotent runs
by default for a while now, but it turns out we don't actually have docs on how to actually use it. This PR adds a quick blurb in our docs to illustrate how a user would use idempotent runs for their enclave.Is this change user facing?
YES
References (if applicable):
Related to, but a direct fix for: #1266