Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate unexpected test errors via the test framework #1559

Merged
merged 5 commits into from Oct 16, 2023
Merged

fix: propagate unexpected test errors via the test framework #1559

merged 5 commits into from Oct 16, 2023

Commits on Oct 16, 2023

  1. Make sure there's no error from the test, and that the error is expos… 

    …ed if it does occur
    Omar committed Oct 16, 2023
    Copy the full SHA
    0b4de0a View commit details
    Browse the repository at this point in the history

  2. Catch errors returned by RunPackage..., so they can be logged

    Omar committed Oct 16, 2023
    Copy the full SHA
    8ea9593 View commit details
    Browse the repository at this point in the history

  3. This was testing runResult in places instead of runResult2. Introduce… 

    …d err2 also to be safe.
    Omar committed Oct 16, 2023
    Copy the full SHA
    52b939f View commit details
    Browse the repository at this point in the history

  4. These tests expect the error populated

    Omar committed Oct 16, 2023
    Copy the full SHA
    20260ae View commit details
    Browse the repository at this point in the history

  5. Add not nil checks on runResult

    Omar committed Oct 16, 2023
    Copy the full SHA
    d9771b3 View commit details
    Browse the repository at this point in the history