fix: propagate unexpected test errors via the test framework #1559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When an unexpected error happens in
enclave_context.RunStarlarkPackageBlocking
, it will return(nil, error)
. Some tests don't account for this, so they don't detect or report said error, then panic when trying to reference thenil
result.This adds
require.NoError(t, err)
to all the tests I could find that hit this codepath.Is this change user facing?
NO
References (if applicable):
#1538