New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added run_sh instruction; users can run one time bash task #717

Merged

Peeeekay merged 9 commits into main from pk/add_run_sh_v1

Jun 13, 2023

Contributor

Peeeekay commented Jun 13, 2023

This is the first PR for this project. In this PR, I have added run_sh task, which borrow logic from add_service and exec to execute one time task. A sample output looks like this:

Screen Shot 2023-06-13 at 11 54 22 AM

There are few todos on here, which will be tackling -- ( the first 4 are high priority)

add ability to copy files from this task
add wait to run_sh task
remove/stop this task once it is completed ( I am leaning towards stop)
file mounts can be absolute and relative ( in this PR only absolute is being supported)
maybe show task as separate entity, it is treated as service atm.

Here is the design spec: https://www.notion.so/kurtosistech/run_sh-Design-Spec-b7f7660fe7004cfe92fb0f8884453cfe?pvs=4

Peeeekay marked this pull request as ready for review

June 13, 2023 15:59

Peeeekay requested review from h4ck3rk3y and leoporoli

June 13, 2023 16:00

Peeeekay commented

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Show resolved Hide resolved

Peeeekay commented

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go Show resolved Hide resolved

leoporoli approved these changes

View reviewed changes

Peeeekay added 9 commits

June 13, 2023 14:48


          feat: added run sh v0

e7ec0b4


          draft pr

42873a5


          added future reference support

f5601cb


          added to test

88ffae1


          fixed linter

b18cab0


          updated test

36f4188


          Fixed the test

fd9581d


          update test

7eb9c41


          addressed comments

85173ab

Peeeekay force-pushed the pk/add_run_sh_v1 branch from 3d9618d to 85173ab Compare

June 13, 2023 19:07

Peeeekay changed the title ~~feat: added run_sh instruction; users can run one time shell task~~ feat: added run_sh instruction; users can run one time bash task

Peeeekay merged commit 566144a into main

29 checks passed

Peeeekay deleted the pk/add_run_sh_v1 branch

June 13, 2023 19:41

kurtosisbot mentioned this pull request

chore(main): release 0.78.4 #721

Merged

Peeeekay added a commit that referenced this pull request


          chore(main): release 0.78.4 (#721)

915a91e

🤖 I have created a release *beep* *boop*
---


##
[0.78.4](0.78.3...0.78.4)
(2023-06-13)


### Features

* added run_sh instruction; users can run one time bash task
([#717](#717))
([566144a](566144a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Co-authored-by: Peeeekay <15133250+Peeeekay@users.noreply.github.com>
Co-authored-by: Peeeekay <Peeeekay@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment