Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Option for comments to be visible inline with work in downloadable PDF please #15

Closed
sgparry opened this issue Mar 17, 2019 · 7 comments

Comments

@sgparry
Copy link

sgparry commented Mar 17, 2019

Currently comments appear as footnotes at the bottom of the downloadable PDF. Where space is limited that is good, but often it is better to see the comment alongside / near the actual work, like the stamps. Can we please have an option on the tool to view the comment inline?

@Kury25
Copy link
Owner

Kury25 commented Mar 18, 2019

Hello, thanks for your feedback.

Are you talking about annotations written next to symbols? What is your idea exactly? to be able to indicate during the annotation the fact of appearing it online in the PDF file? or a global option?

The problem is size, and overlay, which is quite difficult to detect.
For now, what you see on the screen in the edition is not the "exact copy" of what you see in the PDF file. So even if the teacher sets the position of the annotations so that there is no overlap, the generated PDF could be unreadable.

@sgparry
Copy link
Author

sgparry commented Mar 18, 2019 via email

@Kury25
Copy link
Owner

Kury25 commented Mar 19, 2019

ok, thanks for your interesting proposal, I will think about it.

@sgparry
Copy link
Author

sgparry commented May 10, 2019

Scaling back a bit, a fairly simple option that would be a really good start would be based on what was in Moodle prior to MDL-55459 (assignfeedback_editpdf: Add linked comments and markers to PDF). Looking at the code, it does not seem too hard to make the change they introduced optional, allowing you to toggle a comment between 'inline' and 'footnote' - I have filed a bug request, but i would make sense for editpdfplus to have the same feature.

@Kury25
Copy link
Owner

Kury25 commented May 10, 2019

Yes we could simply add an option on the annotations for the pdf rendering. It is true. I'm going to code it for the next version.

@Kury25 Kury25 added this to the Adaptation to Moodle 3.7 milestone May 10, 2019
@Kury25 Kury25 pinned this issue May 10, 2019
@sgparry
Copy link
Author

sgparry commented May 10, 2019 via email

@Kury25 Kury25 closed this as completed May 31, 2019
@Kury25
Copy link
Owner

Kury25 commented May 31, 2019

resolved in d84bac8

@Kury25 Kury25 unpinned this issue May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants