Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Food Recipe project #32

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Food Recipe project #32

merged 2 commits into from
Sep 9, 2022

Conversation

Tommymarvel
Copy link
Collaborator

In this project, we have implemented different functionalities, which include :

  • Using javascript to render objects dynamically
  • We've also added counters to our like button and comment section.
  • We've used Jest to test the functions and it's working perfectly.
  • API is also used in this project for involvement and visuals.
  • Check this LIVE.
  • Watch the presentation.

Note: This is a group of two students.

Copy link

@VICTOR-CHUKWU VICTOR-CHUKWU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team,

STATUS: CHANGES REQUIRED ♻️

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!

Suggested changes

Check the comments under the review.

  • They should be a counter at the top of your page below your nav bar showing the number of items in your page
    Screenshot from 2022-09-09 17-19-35
    kindly add this and your project will be complete

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

@Tommymarvel Tommymarvel closed this Sep 9, 2022
@Tommymarvel Tommymarvel reopened this Sep 9, 2022
@Tommymarvel
Copy link
Collaborator Author

Hi Team,

STATUS: CHANGES REQUIRED

Good job so far! There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!

Suggested changes

Check the comments under the review.

  • They should be a counter at the top of your page below your nav bar showing the number of items in your page
    Screenshot from 2022-09-09 17-19-35
    kindly add this and your project will be complete

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._

Cheers and Happy coding!clapclapclap

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

@VICTOR-CHUKWU Thank you for your time to review the project, we really appreciate it, the counter is there but maybe because of the color, we suggest you re-check

@VICTOR-CHUKWU
Copy link

VICTOR-CHUKWU commented Sep 9, 2022

I just saw it now, kindly resubmit for the next reviewer to approve, and you can make it look more visible, thanks 👏

Copy link

@aimemalaika aimemalaika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi <STUDENT_MENTION>,

In my opinion, your project is ready for presentation! There is nothing else to say other than... it's time to merge it :shipit:

133591850-fdcb7dd3-dd7a-4274-81e7-0e59434148f7

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Tommymarvel Tommymarvel merged commit 820148c into dev Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants