Header section #1
Conversation
this commits adds icon for mobile menu and adds placeholder for logo
it add my self section to gether with the social icons
this commit update background image and align elements properly
It also fix typo error
There was a problem hiding this comment.
Hi @kusiLaw ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔️ No linter errors
✔️ Github flow was correctly used
✔️ Good design
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
index.html
Outdated
| <div class="logo-box header-items"> | ||
| <span>My Logo</span> | ||
| </div> |
There was a problem hiding this comment.
- Kindly ensure your logo has an
<a>tag wrapping it, this is because your logo is supposed to be clickable.
index.html
Outdated
| <section class="presentation"> | ||
| <div class="presentation-content"> | ||
| <div class="text-wrapper"> | ||
| <h2 class="text text-primary">I’m Lawrence <br>Glad to see <br> you!</h2> |
There was a problem hiding this comment.
- Kindly change your header tag to
h1since this is your first header tag, this will make your page optimized for SEO. Also, ensure your design is responsive it currently misplaced some background images when the width is beo 400px, the minimum recommended is 375px.
There was a problem hiding this comment.
thank you very much for the review and suggestions. I don't understand "ensure your design is responsive it currently misplaced some background images when the width is beo 400px, the minimum recommended is 375px" if you can explain much more details for me.
thank you
- change header to h1 - wrap logo with link tag - responsive background image
There was a problem hiding this comment.
Hi @kusiLaw ,
Your project is complete! There is nothing else to say other than... it's time to merge it 🥳
Congratulations! 🎉
Status: Approved✔️
Highlights
- No linter errors
- Good follow-up with previous reviewer.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
this change adds the header section which consists of the logo, the social icons, and my self section for mobile devices