Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property name cannot contain "-" #27

Closed
ost12666 opened this issue Aug 30, 2018 · 3 comments
Closed

Property name cannot contain "-" #27

ost12666 opened this issue Aug 30, 2018 · 3 comments

Comments

@ost12666
Copy link

object ({AUDIO: number, VIDEO: number, SUBTITLES: number, CLOSED-CAPTIONS: number})

This is a build problem with TypeScript (when trying to add types) and will be an exception in run time.

@kuu
Copy link
Owner

kuu commented Aug 31, 2018

I think I've fixed the issue and publish it as a new version 0.2.0.
Can you verify the fix?

@ost12666
Copy link
Author

Yes, I see it now also in the updated doc. Thanks!

BTW If tried almost all HLS parsers and this looks (at least now) like the best and most comprehensive one. I would be very helpful to have TypeScript definitions for it. This is what I did for the parsed objects.
hls-types.ts.zip

@salmoro
Copy link
Contributor

salmoro commented Feb 5, 2019

@ost12666 Thanks for sharing the types. It came in handy for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants