Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Single Column PRIMARY KEY for nodes #216

Closed
3 tasks done
ray6080 opened this issue Jun 26, 2021 · 3 comments
Closed
3 tasks done

Support Single Column PRIMARY KEY for nodes #216

ray6080 opened this issue Jun 26, 2021 · 3 comments
Labels
feature New features or missing components of existing features

Comments

@ray6080
Copy link
Contributor

ray6080 commented Jun 26, 2021

To add the primary key constraint for nodes, following things need to be done:

  • introduce the keyword in the loader, and enable the loading of primary key column into storage as a regular node property. (See Add the concept of primary key for nodes into loader #215)
  • the data type of primary key property should be extended to INT64 if we add it later. Currently, we treat all primary key values as string in the loader.
  • an index (hash index) should be added/used to enforce the constraint of uniqueness.
@ray6080 ray6080 changed the title Support PRIMARY KEY for Nodes Support PRIMARY KEY for nodes Jun 26, 2021
@ray6080 ray6080 added the feature New features or missing components of existing features label Jun 26, 2021
@ray6080 ray6080 mentioned this issue Sep 3, 2021
46 tasks
@semihsalihoglu-uw
Copy link
Contributor

So do we still treat all primary key values as strings? Or do we support string and int64s?

@ray6080
Copy link
Contributor Author

ray6080 commented Oct 17, 2021

So do we still treat all primary key values as strings? Or do we support string and int64s?

Currently, in the loader, we still treat all primary key values as strings.

@semihsalihoglu-uw semihsalihoglu-uw changed the title Support PRIMARY KEY for nodes Support Single Column PRIMARY KEY for nodes Feb 3, 2022
@ray6080
Copy link
Contributor Author

ray6080 commented Sep 6, 2022

I believe this is already done now.

@ray6080 ray6080 closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or missing components of existing features
Projects
None yet
Development

No branches or pull requests

2 participants