You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was in the following situation. I'm parallelizing the writes of the GDS outputs. In this case, each thread needs to create a local copy of an FTable. The current PlanMapper::mapGDSCall passes an actual FTable instead of TableSchema down to the operators (putting this in the GDSCallSharedState). This left me in a situation where I wanted to copy or clone the FTable but there is no such function.
Having talked to @acquamarin apparently normally the frontend passes just the schema and each operator that wants to do parallel writes, e.g., ResultCollector, use this schema to create its local copy with a line like this (see ResultCollector::initLocalStateInternal for an example):
So maybe we should follow this style also in GDSCall. Or we can add a clone function to FTable and pass in FTable in other places too. Regardless, let's be consistent everywhere for code readability.
The text was updated successfully, but these errors were encountered:
I was in the following situation. I'm parallelizing the writes of the GDS outputs. In this case, each thread needs to create a local copy of an FTable. The current PlanMapper::mapGDSCall passes an actual FTable instead of TableSchema down to the operators (putting this in the GDSCallSharedState). This left me in a situation where I wanted to copy or clone the FTable but there is no such function.
Having talked to @acquamarin apparently normally the frontend passes just the schema and each operator that wants to do parallel writes, e.g., ResultCollector, use this schema to create its local copy with a line like this (see ResultCollector::initLocalStateInternal for an example):
So maybe we should follow this style also in GDSCall. Or we can add a clone function to FTable and pass in FTable in other places too. Regardless, let's be consistent everywhere for code readability.
The text was updated successfully, but these errors were encountered: