tidy: remove trivial constructors #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed trivial destructors. Also removed clangd.log, a temporary file that was accidentally committed in #2507.
Riolku
force-pushed
the
tidy-minor-fixes
branch
from
46a7a05
to
bb9237a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2511 +/- ##
=======================================
Coverage 91.56% 91.56%
=======================================
Files 1026 1026
Lines 37947 37947
=======================================
Hits 34748 34748
Misses 3199 3199 ☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Nov 28, 2023
ray6080
reviewed
Nov 28, 2023
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| #include "common/timer.h" | |||
| #include "main/kuzu_fwd.h" | |||
| #include "transaction/transaction_context.h" | |||
There was a problem hiding this comment.
This looks like we are introducing a new include, which wasn't added previously, here?
There was a problem hiding this comment.
Yes because we need access to the transaction context destructor in order to generate the destructor for clientcontext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed trivial destructors. Also removed clangd.log, a temporary file that was accidentally committed in #2507.