-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default config and remove default file transport #17
Conversation
return line; | ||
} | ||
}) | ||
new winston.transports.File(conf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same output format as previous default can be set using
{
level: 'error',
json: false,
filename: 'kuzzle.log',
addDate: true,
timestamp: false
}
package.json
Outdated
@@ -24,18 +24,23 @@ | |||
}, | |||
"license": "Apache-2.0", | |||
"dependencies": { | |||
"kuzzle-common-objects": "^3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we also need "kuzzle-common-object" inside dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. At the minimum it can be moved to dev-dependencies and maybe totally removed.
Putting the PR in wip in the meantime
Description
Related issue