Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default config and remove default file transport #17

Merged
merged 3 commits into from May 10, 2017

Conversation

benoitvidis
Copy link
Contributor

Description

  • Fix default configuration, which was not injecting the proper format
  • Remove the file transport by default, which possibly would cause disk space exhaustion risks
  • Add License headers to prepare SonarCube integration
  • All transports now accept all possible options (excepting functions for obvious reasons).

Related issue

@benoitvidis benoitvidis self-assigned this Apr 20, 2017
return line;
}
})
new winston.transports.File(conf)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same output format as previous default can be set using

{
  level: 'error',
  json: false,
  filename: 'kuzzle.log',
  addDate: true,
  timestamp: false
}

package.json Outdated
@@ -24,18 +24,23 @@
},
"license": "Apache-2.0",
"dependencies": {
"kuzzle-common-objects": "^3.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we also need "kuzzle-common-object" inside dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. At the minimum it can be moved to dev-dependencies and maybe totally removed.

Putting the PR in wip in the meantime

@benoitvidis benoitvidis changed the base branch from master to 2.x May 9, 2017 12:29
@benoitvidis benoitvidis removed the wip label May 9, 2017
@dbengsch dbengsch merged commit 5c1dd5a into 2.x May 10, 2017
@dbengsch dbengsch deleted the fix-16-default-config-and-sonarcube branch May 10, 2017 08:11
@stafyniaksacha stafyniaksacha mentioned this pull request Jun 20, 2017
This was referenced Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants