This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
Add EAST node #1817
Merged
Add EAST node #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamalielhere
reviewed
May 1, 2018
app/scripts/nodes.js
Outdated
| 'blockExplorerAddr': 'https://explorer.easthub.io/addr/[[address]]', | ||
| 'type': nodes.nodeTypes.EAST, | ||
| 'eip155': true, | ||
| 'chainId': 9, |
There was a problem hiding this comment.
Is this accurate? Seems like chainId 9 is registered to Counterparty.
There was a problem hiding this comment.
@gamalielhere Yup. Checked the wrong number sorry 😄
gamalielhere
reviewed
May 2, 2018
| 'blockExplorerAddr': 'https://explorer.easthub.io/addr/[[address]]', | ||
| 'type': nodes.nodeTypes.EAST, | ||
| 'eip155': true, | ||
| 'chainId': 7, |
There was a problem hiding this comment.
7 node is also taken. Please refer to: https://github.com/satoshilabs/slips/blob/master/slip-0044.md
There was a problem hiding this comment.
@gamalielhere Should chainid similar with slip-44 number? We already registered in 7 with parity 😂
gamalielhere
approved these changes
May 3, 2018
|
@akx20000a Can you resolve the conflict? I'll get this merged afterwards |
|
@gamalielhere Done Rebase 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From http://easthub.io