This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
support full 32bit chain_id for trezor #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… simply recalc signature_v
|
typo correction: s/'Trezor nano S'/'Trezor ONE'/1 |
|
@mkrufky oops :) |
|
For the record, this change is required in order to use Pirl on Trezor hardware wallets. cc @masterdubs @pirl |
gamalielhere
approved these changes
Aug 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the following are full 32bit chain_id support fix for Trezor Hard wallet.
for some larger chainId (calculated signature_v is more than uint32_t case), Trezor returns only
signature_vbit (0or1) and this fix simply recalcsignature_vat the client side.there is no backward compatible issue with this fix
(Please see trezor/trezor-mcu#399 for details)