This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
Add Ledger support for Musicoin #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrufky
force-pushed
the
musicoin-ledger
branch
from
6fbff26
to
1de8d83
Compare
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S
homepage : https://musicoin.org
block explorer : https://explorer.musicoin.org
slip0044 index : 184
chainId : 7762959
Musicoin has been unable to work with hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c
The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62
Musicoin is on LedgerHQ official roadmap:
https://trello.com/c/a3YFOxx1/114-musicoin-support
LedgerHQ official Musicoin app support: (merged)
LedgerHQ/app-ethereum#20
mkrufky
force-pushed
the
musicoin-ledger
branch
from
1de8d83
to
fe7e749
Compare
|
@gamalielhere This one fell through the cracks. Didn't realize I hadn't pushed this fix until now. It would really be awesome if we could have this merged and deployed before Ledger's next third party release day coming up on Tuesday. Would that be possible? 🙏 👼 |
gamalielhere
approved these changes
Aug 31, 2018
|
@mkrufky we're building towards a release. It should be before this tuesday. 👍 |
Pirl, Ether-1 and Atheios are now supported in TREZOR ONE firmware version 1.6.3 https://blog.trezor.io/trezor-one-firmware-update-1-6-3-73894c0506d
kvhnuke
approved these changes
Sep 1, 2018
gamalielhere
added a commit
that referenced
this pull request
Sep 4, 2018
gamalielhere
added a commit
that referenced
this pull request
Sep 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S
Musicoin has been unable to work with ledger hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c
The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62
Musicoin is on LedgerHQ official roadmap:
https://trello.com/c/a3YFOxx1/114-musicoin-support
LedgerHQ official Musicoin app support: (merged)
LedgerHQ/app-ethereum#20
Also included in this pull request, as per @gamalielhere 's request:
Pirl, Ether-1 and Atheios are now supported in TREZOR ONE firmware version 1.6.3
https://blog.trezor.io/trezor-one-firmware-update-1-6-3-73894c0506d