Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

bugfix/tx-generation #2134

Merged
merged 3 commits into from
Nov 2, 2018
Merged

bugfix/tx-generation #2134

merged 3 commits into from
Nov 2, 2018

Conversation

gamalielhere
Copy link
Collaborator

@un1t
Copy link

un1t commented Nov 1, 2018

I cloned bugfix/tx-generation branch and executed "npm i && npm run dist"
Number of zeros seems to be correct. But I notice couple more things

  1. When unit is wei, all works fine, but when unit is gwei after refreshing page and generating information value of gas price was 7.1. In gas price range input there is other value, in my case it was 9. Have no idea why gas price 7.1 no matter what value is in gas price range input.

  2. When I tried connect to Ledger, it did not work, and there was error in console:

    etherwallet-master.js:88091 ReferenceError: $ is not defined
    at Object.u2f.isIosChrome_ (etherwallet-master.js:20618)
    at Object.u2f.getMessagePort (etherwallet-master.js:20595)
    at Object.u2f.getPortSingleton_ (etherwallet-master.js:20954)
    at Object.u2f.getApiVersion (etherwallet-master.js:21083)
    at Object.u2f.sign (etherwallet-master.js:21000)
    at Ledger3.exchange (etherwallet-master.js:19874)
    at LedgerEth.getAddress (etherwallet-master.js:19670)
    at ChildScope.$scope.scanLedger (etherwallet-master.js:5226)
    at fn (eval at compile (etherwallet-master.js:88942), :4:150)
    at callback (etherwallet-master.js:101370)

On website connect to Ledger is working, but this in this branch it is not.

@gamalielhere
Copy link
Collaborator Author

@un1t thanks for testing it! Are you serving the static files through a server?

@un1t
Copy link

un1t commented Nov 2, 2018

No previously I just open index.html in dist folder.

Now I tried with server. I see the same errors.

@un1t
Copy link

un1t commented Nov 2, 2018

I tried master branch and I see the same error, I guess it something with build.
Maybe there are additional steps to build it properly or do I need specific version of node.js?

@gamalielhere
Copy link
Collaborator Author

gamalielhere commented Nov 2, 2018

@un1t you need to run npm install; npm run build. Also don't use the master branch. Use mercury. I just made a push that should fix the generation issue. But let me know if it doesn't.

@gamalielhere gamalielhere merged commit a123c0b into mercury Nov 2, 2018
@gamalielhere gamalielhere deleted the bugfix/tx-generation branch November 2, 2018 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants