-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 257 #310
Fix issue 257 #310
Conversation
@kvz could you please rerun the Test for node.js 0.12? |
Thanks for the PR! Sure, running here https://travis-ci.org/kvz/locutus/builds/169943784 |
ok - strange: It's still happening. I take a look at it tonight. |
So thankful for this PR hope it gets merged soon, it fixes some issues with spanish characters like áéíóú, etc. 👍 |
Sorry for not fixing it before - had a busy time. @kvz is there a special reason, why in the project |
@philippsimon I think that's just some poor taste from 2007-me tbh. Thanks for the fixes! And especially adding the tests & attribution! ❤️ Merging this. |
@kvz hahaha - ok ;) and you're very welcome for that fix. I'm really happy that you started this project! |
@kvz Hi! Any plans to release this PR any time soon? 🙏 |
2.0.6 was just released! |
Description