Fix issue 257 #310

Merged
merged 3 commits into from Nov 1, 2016

Projects

None yet

3 participants

@philippsimon
Contributor
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

@philippsimon
Contributor
philippsimon commented Oct 23, 2016 edited

@kvz could you please rerun the Test for node.js 0.12?
I tested it on my computer and this weird error in Travis didn't happen there.

@philippsimon philippsimon referenced this pull request Oct 23, 2016
Closed

Unserialize enconding #257

@kvz
Owner
kvz commented Oct 24, 2016

Thanks for the PR! Sure, running here https://travis-ci.org/kvz/locutus/builds/169943784

@philippsimon
Contributor

ok - strange: It's still happening. I take a look at it tonight.

@geriux
geriux commented Oct 30, 2016

So thankful for this PR hope it gets merged soon, it fixes some issues with spanish characters like áéíóú, etc. 👍

@philippsimon
Contributor

Sorry for not fixing it before - had a busy time.
I got it fixed by using function _unserialize (data, offset) { instead of var _unserialize = function (data, offset) {

@kvz is there a special reason, why in the project var functionName = function(...) is always used instead of the more common form function functionName (...)?

@kvz
Owner
kvz commented Nov 1, 2016

@philippsimon I think that's just some poor taste from 2007-me tbh.

Thanks for the fixes! And especially adding the tests & attribution! ❤️ Merging this.

@kvz kvz merged commit 61c2211 into kvz:master Nov 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@philippsimon
Contributor

@kvz hahaha - ok ;) and you're very welcome for that fix. I'm really happy that you started this project!

@geriux
geriux commented Nov 4, 2016

@kvz Hi! Any plans to release this PR any time soon? 🙏

@kvz
Owner
kvz commented Nov 8, 2016

2.0.6 was just released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment