Skip to content
This repository has been archived by the owner on Jul 29, 2020. It is now read-only.

menu in bounds issue #33

Closed
lm-ao opened this issue Feb 23, 2018 · 6 comments
Closed

menu in bounds issue #33

lm-ao opened this issue Feb 23, 2018 · 6 comments

Comments

@lm-ao
Copy link

lm-ao commented Feb 23, 2018

basically if you click close to the outside of the checkbox it will enable it, shouldn't it be only when clicked inside of it?

@lm-ao
Copy link
Author

lm-ao commented Feb 23, 2018

correction the check boxes will turn on if you click on the text that's beside them wouldn't that be a bug and if it's meant to be like that how would you fix it?

@Monsterxsync
Copy link
Contributor

Monsterxsync commented Feb 23, 2018

I don't know what way was intended but the "fix" for this is very simple just change it like this.
#34

@kwilcz
Copy link
Owner

kwilcz commented Feb 23, 2018

It was intended, checkbox selectable is so small that its much easier to use it that way.
I'll leave it for discussion maybe?

@Monsterxsync
Copy link
Contributor

Played one game with only the checkboxes and it seems alright (after i got used it it).

@kwilcz kwilcz closed this as completed in 135cb9b Feb 24, 2018
@ghost
Copy link

ghost commented Feb 25, 2018

It's Wando's decision, but the expected behaviour from a user would be that clicking the text activates the checkbox too. This is how it works on the web, and it can feel fiddly without it.

my 2c

@Monsterxsync
Copy link
Contributor

Monsterxsync commented Feb 25, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants