Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pen Input #106

Closed
sunnypol92 opened this issue Sep 30, 2021 · 2 comments · Fixed by #111
Closed

Pen Input #106

sunnypol92 opened this issue Sep 30, 2021 · 2 comments · Fixed by #111
Assignees
Labels

Comments

@sunnypol92
Copy link
Contributor

No description provided.

@sunnypol92 sunnypol92 self-assigned this Sep 30, 2021
@sunnypol92 sunnypol92 linked a pull request Oct 1, 2021 that will close this issue
@sunnypol92
Copy link
Contributor Author

@soyef-bit have a look at the doc grammar

@soyef-bit
Copy link
Contributor

@sunnypol92

  • Check the doc for image property, if it is correct

  • expandFrom: there is a link here in the svelte file which doesn’t appear in the page

  • the hide_colorpicker property could be made the other way around, where the the property is called colorpicker and false means “don’t show colorpicker'. Currently false means "show colorpicker" because of how the property is named. Just a suggestion

  • The pen input is actually a + pattern with trails. This is especially visible when the lineWidth is a bigger number. The + input randomly rotates and leaves artifacts of diagonal lines when in larger lineWidth. I think the drawing lines can be smoother, even in small lineWidth, if the input could be a circular dot or square instead?

  • What is the circle input? It is a square that is not even transparent. It is a white box with a grey filled circle inside. I'm not sure of it's usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants