-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gen 7 legality bugs #377
Comments
Looking through more of my boxes I can see that legality is definitely still being worked on. If you need more examples just let me know! |
Still a WIP; the Static Encounters (basically an 'encounter' that can be forced) have not been fully mapped location wise. https://github.com/kwsch/PKHeX/blob/master/PKHeX/Legality/Tables7.cs#L127 The Location of each is still not researched. Second image probably isn't a static encounter but related to the evolution checks. |
i been having same issue, it has been fixed or is it work in progress? thanks for the work tho is truly appreciate it |
I have a legality problem with Grass Pledge on my Decidueye, even though it learnt it legally through an in-game move tutor. I assume it's just something that hasn't been added in yet but I thought I'd mention it here just in case. |
i Have a legality problem with all the mons i've generated as eggs. The first evo is ok, but when they evolve they gives many errors on the relearn moves. in some cases it says expected 2 identical moves, in other cases when i fullfill the expected moves it gives another error on one of the previous ok moves... |
#377 Also removes unnecessary variable for 'games', can just use the created array.
try to open this, check the Party Box, check the first 4 pokemons (3 starters and the grass one) they have all the same problems with relearn moves, try to add them and you will get another error. what is wrong? |
All party pokemon appear valid with the commit that was just pushed. |
How would I got about contributing changes to the Table7 to fix location' legality errors? There's a surprising lack of comments in these files... |
Catch a static encounter, report the met location here or on the forums (with pk7 or met location ID). |
I mean, I'm a very experienced C# coder, I was going to branch and contribute. |
Here is the PK7 though. The Litwick appeared after I did an "Island Scan" after doing the 10 QR codes to get enough points. Showed up at the Hau'oli Cemetery. |
Ha, it's just that PKHeX does a lot and not everything on the inside is obvious what it does. PKHeX stores a list of the "Static Encounters". They're basically a set encounter that can be initiated by the game's scripting engine. The raw data doesn't contain the met location, as the scripting just says "start stationary encounter 42"; met location is set on capture. Which requires that data to be mapped by hand. These tables are stored in PKHeX in their generation-specific Legality tables. I've highlighted the scanned ones. I haven't played the games so I don't know if these scanned pokemon can manifest multiple met location IDs for the same static encounter. Feel free to replace the Location (currently -1) with whatever value the Pokemon has. In your case, the Litwick is @ location ID 38 (Hau’oli Cemetery), so -1 => 38. Since there's so many, it's easier to just compile a list on the forums instead of managing dozens of pull requests :) |
Hanu hanu beach have static encounters of sandygast and staryu
|
if they say invalid after i save, will it make my pokemon illegal to use ? for online play? |
Some more missing:
Here are the pk7s for the above: pk7.zip |
Any idea why this is considered illegal? Lake of the Sunne is an area in Moon, but when I change it the met location to Lake of the Moone (an area in Sun), PKHeX deems it legal. The same goes for origin game of Sun and met location of Lake of the Sunne |
Zygarde (10%) gives error "not valid encounter" but it is created in Route 16 if i remember correctly so it should be ok |
A question: time ago the famous leaker (that got all his leaks right) talked about the possibility to bring in SuMo, from Virtual Console Red-Yellow-Blue, the pokemon. In that case he told that they retained their original type (example: Jigglypuff Normal, not fairy) and different stats. So, have you found something in the code that leads to this thing? there is a way to have one pokemon (ex: jigglypuff) with different stats and types? or it was fake and once transferred from R/Y/B they get new types and stats? Is it possibile that the Pikachu transferred from Yellow will get the hat? |
Issues with greninja legality, ultrabeasts also give an error. Hopefully is fixed soon. Good job on the updates dev :) |
@sora10pls Because a cosmog from Lake of the Sunne in Moon is illegal -- the one you obtain is from the Lake of the Moone. That's...the correct behavior. |
My mistake haha, I assumed the Lake would stay that of the opposite version after entering the portal. As for more legality issues, the latest commit seems to have added proper legality checks for all Ultra Beasts but two. Here is the proper met info I've obtained for both @kwsch |
For some * I'll add the two you've listed, still many to go :) |
@kwsch Exception Error for pk6 pokemon still occur in the latest build... |
Add checks for out-of-range species IDs. #377
Starters with their hidden abilities are deemed legal on PKHeX, but after testing them online, they wouldn't go through. I thought I may have messed up met info, but to be sure, all I did was change their abilities. After I did that, they went through online, so it means their hidden abilities are unreleased |
Hard-coding a hidden ability banlist is no fun and can be tedious to update; for gen6 PKHeX left it up to the user to know whether or not the ability is released or not. |
Thanks Sora for the .pK7, can you give us also the Solgaleo one captured in sun? ty! BTW i'll add today here the save with all the mons and UB captured in my moon, so you can check for other legality issues about the met locations of UBs and so remember also, if possibile, to add a value modifier of Festival Coins and Zygarde Cells (zygarde is still market illegal for the met location) |
ah, check #399 because Minior is still marked as illegit even after that update you did |
I have some legality issue with these legally obtained pokemon: Butterfree, Kadabra, Sneasel, Cottonee, Braviary, Zygarde 10%, Toucannon, Passimiam and Minior. |
This might not be a bug because I've only heard two people reporting this and have yet to get confirmation from a reliable source, but the word is that when breeding a male and female of the same species in SM, the offspring has a 50% chance of inheriting the father's Poké Ball instead of the mother's. If true, this means that any two-gender species that can be caught with a Safari, Sport, or Apricorn Ball can be bred with that ball and its hidden ability, and any two-gender species found with the QR Scanner can be bred with a Beast Ball and its hidden ability. It would be great if someone could confirm if this is true or not (and if it is, also check Nidoran and Volbeat/Illumise to see if they're considered the same species for ball inheritance). Also, Eevee hatched from an egg is mistakenly interpreted as a gift Eevee ("Static encounter relearn move mismatch/Incorrect ball on ingame gift.") |
Some Pokemon reported legal by PKHeX are deemed illegal by the game. Example: |
Is Hawlucha even available in the games? People importing parents from Gen6 would obviously trip the online species banlist. |
Ah, good point -- my bad. |
The Pledge moves are flagged as illegal on all but the final stages of the starters, while Frenzy Plant, Blast Burn, and Hydro Cannon are recognized as legal on all stages. I realize this matches up with the datamined learnsets, but given that the reverse has been true for as long as those moves have existed, are we sure the names didn't get swapped during the datamining? Also, right clicking on Current Moves for a starter gives the aforementioned moves as suggested moves, which I'm pretty sure shouldn't happen. |
I know these are being worked on, but I got a Cyndaquil on Route 3 via the Island Scan feature--this is one of the Static Encounters in the game--and it comes up as illegal. I assume it's just a matter of figuring out what each of these are, since the Static Encounters haven't fully been explored yet. Cyndaquil was level 12 and carried Double Kick, an egg move. My friend also obtained Litwick in Hau'oli Cemetary at level 10, knowing Acid, using the Island Scan. |
Zygarde with the core enforcer and similar moves are still marked as illegal . Same for his met location. Also kartana has the same location problem and ash greninja Inviato da iPhone
|
Steele bounsweet and the other evolution cannot be male only female Inviato da iPhone
|
Rather than make a new bug, I'm just going to put this here: In Sun and Moon you can "re-learn" moves from higher levels at lower levels. For example, Pheromosa learns High Jump Kick at level 67, but with the move re-learner you can teach it High Jump Kick at level 60 which you catch it at. This is currently marked as an illegal move in PKHeX even though I did it solely through in-game means. |
Obviously. They still haven't been added because nobody has documentation on level ranges or restrictions. |
Doesn't seem like anyone's brought this up yet - you can now learn higher-level moves through the Move Reminder in game, but PkHex reports them as being illegal/unknown moves until the poke hits the required level. Also, Alolan Vulpix is a valid encounter in Sun at Tapu Village, but PkHex reports it as being illegal. I didn't test it with Alolan Sandshrew in Moon, but I imagine the same issue applies. |
So has Vulpix's issue. Closing this issue, as the catch-all is no longer required. Still missing Poke Pelago / Scan locations. |
The following were obtained legitimately in game and are deemed illegal (says "Not a valid encounter." for both)
The text was updated successfully, but these errors were encountered: