Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distance error: #7

Closed
zhunnan opened this issue Jul 1, 2021 · 4 comments
Closed

distance error: #7

zhunnan opened this issue Jul 1, 2021 · 4 comments

Comments

@zhunnan
Copy link

zhunnan commented Jul 1, 2021

I test pair_file: ["/SG_PR_DATA/graphs_sk/05/000000.json","/SG_PR_DATA/graphs_sk/05/000006.json"] in eval_pair.py.
The rusult score more than 1.
------------------------------------------------------------------------------console output:
Enumerating unique labels.

{0: 0, 1: 1, 2: 2, 3: 3, 4: 4, 5: 5, 6: 6, 7: 7, 8: 8, 9: 9, 10: 10, 11: 11}
12
loading model: ./model/model.pth
distance error: 3.3904110318197205

I,m confused.

@kxhit
Copy link
Owner

kxhit commented Jul 2, 2021

It throws an error from the code here. Because the distance between the two scenes (000000 and 000006) is between 3m-20m, which is not considered as explained in our paper. You can change the code here to measure each two scenes similarity anyhow. Let me know if you have other confusions.

@zhunnan
Copy link
Author

zhunnan commented Jul 2, 2021

In xxx.json, how to get the pose data? If I only get topo point and it's label of every frame (in your work ,refers to [centers] and [nodes]), can I get similar score between two any frames without pose?
I 'd like to test a sequese in this way. Thanks for your answer!

@kxhit
Copy link
Owner

kxhit commented Jul 2, 2021

Pose data is from KITTI dataset and you can get similar score between two any frames without pose as we don't need pose in infer. Pose data is only used for evaluation and training as we need pose to define which pair is positive (distance less 3m) and which is negative (distance over 20m).
You can modify the code and give fake pose (e.g. 000) in inference to obtain the similar score regardless of their true related pose. However, in this way you may not know the two pair is a real loop closure or not.

@zhunnan
Copy link
Author

zhunnan commented Jul 2, 2021

Nice

@zhunnan zhunnan closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants