Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio feature for crate #64

Closed
attila-lin opened this issue Apr 19, 2023 · 2 comments
Closed

Add audio feature for crate #64

attila-lin opened this issue Apr 19, 2023 · 2 comments

Comments

@attila-lin
Copy link
Contributor

attila-lin commented Apr 19, 2023

Hello~

In my use case, I don't need to play the audio.

So add a audio feature to play the audio which contains the deps for this job will be nice for users like me to reduce the deps.

@kxxt
Copy link
Owner

kxxt commented Apr 19, 2023

Actually I wanted to separate the dependencies for the bin and lib from the very start of RIIR. Unfortunately it is not possible(rust-lang/cargo#1982).

So add a audio feature to play the audio which contains the deps for this job will be nice for users like me to reduce the deps.

It is the best workaround we can use for now. I will add a binary feature so that clap, env_logger and rodio are not required for the lib.

I don't need to play the audio.

Actually the rust lib doesn't have any API to play the audio. I have no plan to support it until there is an asynchronous playback API. rodio uses a multi-thread approach and it won't play well with tokio.

@kxxt
Copy link
Owner

kxxt commented Apr 20, 2023

Implemented in v5.1.0.

@kxxt kxxt closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants