Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken skia build #108

Closed
kyamagu opened this issue Sep 4, 2020 · 3 comments
Closed

Broken skia build #108

kyamagu opened this issue Sep 4, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@kyamagu
Copy link
Owner

kyamagu commented Sep 4, 2020

Describe the bug
Windows CI build fails

To Reproduce
Launch build in Github Actions windows runner

Expected behavior
Build should succeed.

Desktop (please complete the following information):

  • OS: macOS 10.15.6
  • Python: n/a
  • skia-python version: v85.0

Additional context
See https://skia.googlesource.com/skia/+/0d6f81593b1fa222e8e4afb56cc961ce8c9be375

https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes#16.7.0
https://github.com/microsoft/STL/wiki/Changelog#vs-2019-167
@kyamagu kyamagu added the bug Something isn't working label Sep 4, 2020
@kyamagu
Copy link
Owner Author

kyamagu commented Sep 4, 2020

Rel: microsoft/STL#482

@kyamagu
Copy link
Owner Author

kyamagu commented Sep 4, 2020

Perhaps the easiest fix is to upgrade to milestone 86 release

@kyamagu
Copy link
Owner Author

kyamagu commented Sep 11, 2020

Fixed #109

@kyamagu kyamagu closed this as completed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyamagu