Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible specification of sky locations? #67

Open
kyleaoman opened this issue Jun 19, 2024 · 0 comments
Open

More flexible specification of sky locations? #67

kyleaoman opened this issue Jun 19, 2024 · 0 comments
Assignees
Milestone

Comments

@kyleaoman
Copy link
Owner

kyleaoman commented Jun 19, 2024

Currently the source and data cube accept (or set internally) an RA and a Dec. It would be possible to leverage astropy's coordinate module to offer more flexibility:

  • Would be good to be able to define the source directly in Galactocentric coordinates, such as from Sibelius (x, y, z) coordinates with the Galaxy at the origin. In this case initializing with RA, Dec and distance doesn't make sense, these become derived quantities, so need to re-think the __init__ or offer a classmethod.
  • Instead of RA and Dec one might want to specify l and b in Galactic coordinates, or generally other systems. The __init__ arguments could be restructured to take a SkyCoord?

Vaguely related and may as well be done at the same time:

  • Systemic velocity could have an option to be a vector.
@kyleaoman kyleaoman self-assigned this Jun 19, 2024
@kyleaoman kyleaoman added this to the v2.2 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant