Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 3.11 #65

Closed
gayu-thri opened this issue Apr 5, 2023 · 3 comments
Closed

Support for Python 3.11 #65

gayu-thri opened this issue Apr 5, 2023 · 3 comments

Comments

@gayu-thri
Copy link

gayu-thri commented Apr 5, 2023

Just wanted to follow up on this, it would be helpful if you could provide some clarification on this matter

@kylebgorman

The dockerfile setup we have now doesn't seem to pull in Python 3.11 so that may be some additional work in the future.

Just wanted to clarify on this point.

When I was trying to generate wheel files using the Dockerfile, I was able to get Python 3.11 pulled (cp311) and the above message that I shared earlier in #64 stating that it's working fine in Python 3.11 also was by making use of this wheel file.

image

Originally posted by @gayu-thri in #64 (comment)

@gayu-thri
Copy link
Author

I don’t think I saw Python 3.11 wheels on my system but it’s possible I missed something. Is it likely we got different outputs from the same dockerfile?

On Wed, Apr 5, 2023 at 1:34 AM Gayathri Ethiraj @.> wrote: Just wanted to follow up on this, it would be helpful if you could provide me with clarification on this matter @kylebgorman https://github.com/kylebgorman The dockerfile setup we have now doesn't seem to pull in Python 3.11 so that may be some additional work in the future. Just wanted to clarify on this point. When I was trying to generate wheel files using the Dockerfile, I was able to get Python 3.11 pulled (cp311) and the above message that I shared earlier stating that it's working fine in Python 3.11 also was by making use of this wheel file. [image: image] https://user-images.githubusercontent.com/39553592/229047449-674b7603-1d90-4757-8a8a-23622c850f9e.png — Reply to this email directly, view it on GitHub <#64 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OOKO7QZUBO7T5LNPLLW7UOCBANCNFSM6AAAAAAUSU45UQ . You are receiving this because you were mentioned.Message ID: @.>

I also just tried pulling the current version of Dockerfile (with some minor changes you've introduced) and generate the wheels again to confirm this, I am still able to get Python 3.11 cp wheel files generated.

image

Link for the generated wheel file for Python 3.11 here
https://drive.google.com/file/d/1TmIhuKOfSpXQ5euNsBB3tGV8XUHDa_9V/view?usp=share_link

@kylebgorman
Copy link
Owner

Okay, fine, uploaded, thanks for that. In the future though I don't know if I will do this sort of thing again: that is, if when I make a Pynini release the highest Python version is 3.X, I won't be adding 3.$(X + 1) support after the fact unless there is a very long lag between Pynini releases.

@gayu-thri
Copy link
Author

It works now on Python 3.11. Thank you for the taking the time to address the issues.

In the future though I don't know if I will do this sort of thing again: that is, if when I make a Pynini release the highest Python version is 3.X, I won't be adding 3.$(X + 1) support after the fact unless there is a very long lag between Pynini releases.

Yes, I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants