Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morphological thinnig algorithm bug #183

Open
roymacdonald opened this issue Jan 19, 2016 · 1 comment
Open

Morphological thinnig algorithm bug #183

roymacdonald opened this issue Jan 19, 2016 · 1 comment

Comments

@roymacdonald
Copy link
Contributor

Hi Kyle,
hope you're doing well.
I found a bug in the morphological thinning algo.
Check this screenshot
screen shot 2016-01-19 at 15 00 33

Probably when using it on images with thin lines it might work but as you can see when lines are wider it doesn't behave well.
What's going on is that the thinning is being done over the original image, thus the evaluation for each pixel is being done over the already modified image generating a wrong evaluation. The fix is quite simple, just create a copy of the original image that's used for evaluation and modify the original.
I have this fix already made. Should I PR?
best

@kylemcdonald
Copy link
Owner

absolutely! please make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants