This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Add controller liveness probe with controller flow #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasiu001
added
the
area/service-management
jasiu001
requested review from
adamwalach,
mszostok,
piotrmiskiewicz,
PK85 and
polskikiel
as code owners
mszostok
reviewed
Sep 25, 2019
| @@ -138,8 +138,8 @@ spec: | |||
| command: | |||
| - curl | |||
| - localhost:{{ .Values.ctrl.statusPort }}/live | |||
| periodSeconds: 10 | |||
| timeoutSeconds: 2 | |||
| periodSeconds: 300 | |||
There was a problem hiding this comment.
liveness with 5minutes periods? maybe start with 1minute, processing such event should not kill us. IMO 5min is definitely too much
internal/health/health.go
Outdated
| } | ||
|
|
||
| lg.Infof("[liveness-probe] Creating liveness probe addonsConfiguration in %q namespace", probeNamespace) | ||
| err := client.Create(context.TODO(), addonsConfiguration) |
There was a problem hiding this comment.
you already have the context in req *http.Request just pass that into this function
internal/health/health.go
Outdated
| lg.Infof("[liveness-probe] Creating liveness probe addonsConfiguration in %q namespace", probeNamespace) | ||
| err := client.Create(context.TODO(), addonsConfiguration) | ||
| if err != nil { | ||
| lg.Infof("[liveness-probe] Cannot create liveness probe addonsConfiguration: %s", err) |
There was a problem hiding this comment.
lg.Infof? same question for other occurrences
polskikiel
reviewed
Sep 26, 2019
internal/health/health.go
Outdated
|
|
||
| lg.Info("[liveness-probe] Waiting for liveness probe clusterAddonsConfiguration desirable status") | ||
| err = wait.Poll(1*time.Second, 10*time.Second, func() (done bool, err error) { | ||
| key := types.NamespacedName{Name: probeName, Namespace: v1.NamespaceAll} |
There was a problem hiding this comment.
u didn't need to set namespace there
internal/health/health.go
Outdated
| return false, nil | ||
| } | ||
| if err != nil { | ||
| return false, err |
There was a problem hiding this comment.
don't return err, log it
| lg.Info("[liveness-probe] Liveness probe addonsConfiguration not found") | ||
| return false, nil | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
don't return error, log it
polskikiel
approved these changes
Sep 26, 2019
mszostok
added
the
kind/feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #29
Task #29 mentions about readiness probe but both work similarly: they check containers under a given endpoint periodically. The difference are:
(additionally readiness is run at the beggining to check if traffic can be directed to pod)
According to this bug liveness probe is IMO more desirable, the container should be restarted if the controller cannot handle resources.