Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Move addon liveness-probe creation to system namespace #62

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

ksputo
Copy link
Contributor

@ksputo ksputo commented Dec 5, 2019

Description
Helm-Broker liveness probe creates sample AddonsConfiguration and ClusterAddonsConfiguration resources, which results in addons showing up on Kyma Console with status failed, which is misleading to users.

Changes proposed in this pull request:

  • Moved creation of "liveness-probe" AddonsConfiguration from default to system namespace

Related issue(s)

#6359

@ksputo ksputo force-pushed the fix-liveness-probe-namespace branch from 5863bee to 62f3c7c Compare December 5, 2019 14:39
Copy link
Contributor

@polskikiel polskikiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polskikiel polskikiel merged commit 99b8750 into SAP-archive:master Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants