Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose license #3

Closed
kynan opened this issue Jan 21, 2016 · 10 comments
Closed

Choose license #3

kynan opened this issue Jan 21, 2016 · 10 comments

Comments

@kynan
Copy link
Owner

kynan commented Jan 21, 2016

@minrk, @mforbes, can we please decide on a license? I'd choose a permissive license like MIT.

@kynan kynan self-assigned this Jan 21, 2016
@mforbes
Copy link
Contributor

mforbes commented Jan 22, 2016

I am fine with any license.

@minrk
Copy link
Contributor

minrk commented Jan 22, 2016

MIT/BSD is always my preference. My original gist is Public Domain, so do whatever you prefer.

@mforbes
Copy link
Contributor

mforbes commented Jan 22, 2016

The only issue I can imagine right now is that the best solution for using this mercurial might be as an extension, which would probably have to be compatible with GPLv2. This would preclude me from including an extension with this project, but I think that is reasonable. Such an extension should probably be distributed on its own anyway.

http://www.third-bit.com/2010/04/12/the-chilling-effect-of-the-gpl.html

@kynan
Copy link
Owner Author

kynan commented Jan 23, 2016

Given that MIT (== X11) is GPLv2 compatible I'll go for that.

@mforbes
Copy link
Contributor

mforbes commented Jan 23, 2016

It is not backwards compatible: i.e. one still cannot include a mercurial extension here, but as I said, I don't think that is a real problem. I have updated PR #2 to include the MIT license and some classifiers.

One issue: if you install this from PyPI, I don't think that the git filters will get installed. They probably need to be installed in a MANIFEST.in file. Also, do you have any good idea how to make these accessible to users when the package is installed from PyPI? In my project I added a script that can be sourced to set the users environmental variables. Do you have a better suggestion?

@kynan
Copy link
Owner Author

kynan commented Jan 24, 2016

Git filters are per repository and they should not be installed globally when one installs nbstripout. So this is intended behaviour and I don't think there is an issue.

@mforbes
Copy link
Contributor

mforbes commented Jan 24, 2016

I can never remember where things are, so like to be able to run or source a single command mmf_setup which does whatever needs to be done to install hooks etc. in a repository. Thus, I thought it might be useful to include the script in the manifest so it can be programmtically installed by a script from os.path.basename(nbstripout.__file__) for example.

@kynan
Copy link
Owner Author

kynan commented Jan 24, 2016

I don't think I fully understand your use case @mforbes. For a Git repository you simply run nbstripout install to install the hook. I suppose we could augment this task to also work in Mercurial repositories (we're already testing whether we're inside a Git repository, so this could simply be extended).

@kynan
Copy link
Owner Author

kynan commented Jan 24, 2016

We now have an MIT license (added by #2).

@kynan kynan closed this as completed Jan 24, 2016
@mforbes
Copy link
Contributor

mforbes commented Jan 24, 2016

Ah. Okay, I think I understand now. I will see if I can do something similar with mercurial.

@kynan kynan modified the milestone: 0.2.0 Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants