Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect bids with missing nonces #110

Closed
mslipper opened this issue Mar 22, 2020 · 2 comments · Fixed by #116
Closed

Automatically detect bids with missing nonces #110

mslipper opened this issue Mar 22, 2020 · 2 comments · Fixed by #116
Assignees
Labels
enhancement New feature or request

Comments

@mslipper
Copy link
Contributor

Currently, Bob will display an opaque error if users attempt to reveal bids with missing nonces. Rather than displaying an error, we should instead display a warning on the auction screen that gives users the option to import the nonce graphically.

@mslipper mslipper added the enhancement New feature or request label Mar 22, 2020
@mslipper
Copy link
Contributor Author

mslipper commented Mar 23, 2020

For bids with missing nonces:

  • Display a warning underneath the TLD with a link to an import bid modal
  • Modal just displays an import bid field and a button that calls the import RPC call with the right address
  • The 'reveal' button should say 'Nonce import needed' and display the modal until a valid nonce is inputted
  • Can create a new RPC endpoint within hsd that exposes whether or not you have the blind

@mslipper
Copy link
Contributor Author

Draft PR EOW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants