New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new module: jarsigning #101

Open

zml2008 opened this issue Nov 7, 2022 · 1 comment · May be fixed by #110

Labels

type: enhancement

Member

zml2008 commented Nov 7, 2022

There's a very rough version of this in the Configurate codebase at https://github.com/SpongePowered/Configurate/blob/ea78b5c003ecf917b1081da24a01619bc2d22743/build-logic/src/main/groovy/org.spongepowered.configurate.build.publishing.gradle#L22

This implementation is quite brittle at the moment, rough improvements:

support different property names
support providing a toolchain to configure the jarsigner version used
allow signing different outgoing configurations, to avoid junk like https://github.com/SpongePowered/Configurate/blob/ea78b5c003ecf917b1081da24a01619bc2d22743/format/yaml/build.gradle#L37

zml2008 added the type: enhancement label

Member Author

zml2008 commented Nov 7, 2022

We can use https://docs.oracle.com/en/java/javase/19/docs/api/jdk.jartool/module-summary.html for JDK 9+, to have a nice typesafe way of accessing the jar signer

zml2008 linked a pull request

that will close this issue

feat(jarsigner): initial progress on module #110

Open

zml2008 added this to the 3.1.0 milestone

zml2008 removed this from the 3.1.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment