Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search failed and "403 For bidden" is displayed #7

Open
eijenson opened this issue Feb 3, 2018 · 3 comments
Open

Search failed and "403 For bidden" is displayed #7

eijenson opened this issue Feb 3, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@eijenson
Copy link

eijenson commented Feb 3, 2018

Hi.
Thank you very good tool!

It fails with this command(Not necessarily)
$ ghkw heigth height

results:

403 Forbidden
& {%! s (* http.gzipReader = & {0xc420060400 0xc420150580 <nil>})%! s (func () = <nil>)}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code = 0 × 1 addr = 0 × 0 pc = 0 × 1291 e 67]

goroutine 52 [running]:
main. (* Searcher) .searchRequest (0xc4201802e0, 0x7ffeefbffb0c, 0x6, 0xc42007c240)
/Users/XXXX/go/src/github.com/kyoshidajp/ghkw/cli.go:134 + 0x2a7
created by main. (* Searcher) .search
/Users/XXXX/go/src/github.com/kyoshidajp/ghkw/cli.go:144 + 0xbf

Note: XXXX is probably your user name.

Running it several times may succeed.

@kyoshidajp kyoshidajp added the bug Something isn't working label Feb 4, 2018
@kyoshidajp
Copy link
Owner

Thanks for your detail report.

I guess that this is probably over the limit of GitHub API limitation.

By the way, the problem code about this is here.
https://github.com/kyoshidajp/ghkw/blob/v0.0.1/cli.go#L127-L129

If got error code, then should stop goroutine function which searches request safely.

@kyoshidajp
Copy link
Owner

And similar to #3

@kyoshidajp
Copy link
Owner

Search API returns X-RateLimit-Remaining header which is over one when got 403 error.

I've posted this issue at a community forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants