Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help Wanted] Rewrite to Strict TypeScript #13

Closed
kyranet opened this issue May 5, 2019 · 5 comments
Closed

[Help Wanted] Rewrite to Strict TypeScript #13

kyranet opened this issue May 5, 2019 · 5 comments
Milestone

Comments

@kyranet
Copy link
Owner

kyranet commented May 5, 2019

Describe the issue

Veza already supports TypeScript via its typings, but it's support for TS could be greatly improved by rewriting it to strict TypeScript. This might as well fix some hidden bugs.

@kyranet kyranet pinned this issue May 5, 2019
@kyranet kyranet added this to the 1.0.0 milestone May 5, 2019
@dshubhadeep
Copy link
Contributor

@kyranet This seems interesting. I would like to work on this.

@dshubhadeep
Copy link
Contributor

@kyranet How do you want me to proceed ?

@kyranet
Copy link
Owner Author

kyranet commented May 18, 2019

Naturally, forking the repository, rewriting it to TS, and PRing it back. Obviously notifying it here (so people can know you're working on it). In case of doubt, you can ask me anytime 👍

@dshubhadeep
Copy link
Contributor

@kyranet Hey, I have submitted a pull request.
I have converted the js files, but there were some errors that I wasn't able to resolve, such as Object is possibly null and some type errors.
Let me know if there are any additional changes.

@kyranet
Copy link
Owner Author

kyranet commented May 21, 2019

Fixed in #15

@kyranet kyranet closed this as completed May 21, 2019
@kyranet kyranet unpinned this issue May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants