Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): special case inconsistently-cased paths in LLVM build #4540

Merged
merged 5 commits into from
Jun 3, 2020

Conversation

shahms
Copy link
Contributor

@shahms shahms commented Jun 3, 2020

Fixes #4535

@shahms shahms requested review from zrlk and a team June 3, 2020 14:12
Co-authored-by: John Edmonds <john.a.edmonds@gmail.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 3, 2020
Co-authored-by: John Edmonds <john.a.edmonds@gmail.com>
@shahms
Copy link
Contributor Author

shahms commented Jun 3, 2020

Ugh, I knew I shouldn't have done that.

@johnedmonds any chance you can go to https://cla.developers.google.com/ and sign the Google CLA? Our compliance bot is picky and because I applied the changes from the web UI rather than manually it's going to attribute them to you. If you don't want to sign the CLA I can (probably?) revert the auto-commits and make the fixes myself.

@johnedmonds
Copy link
Contributor

johnedmonds commented Jun 3, 2020

Sorry about that. Any chance you could change the author to jedmonds@spotify.com which has signed the CLA? (I just changed the default address on my profile page if that helps.) Otherwise, you can just revert and re-apply the changes yourself.

@shahms
Copy link
Contributor Author

shahms commented Jun 3, 2020

I don't believe I can (or at least, have no idea how I would), but I believe you should be able to add the @gmail.com address at the linked page?

@johnedmonds
Copy link
Contributor

johnedmonds commented Jun 3, 2020

Done. Signed the CLA 👍 .

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 3, 2020
@shahms shahms merged commit 8179c1a into kythe:master Jun 3, 2020
@shahms shahms deleted the macos-case-hack branch June 3, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM doesn't build on MacOS
4 participants