fix(rust): Fixes the kzip generation #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arm1stice FYI |
The old code filled FileInfo.path with a path relative to the corpus root, but should instead have filled it with a path relative to the build directory. Added a regression tests, and added *most* of an integration test which runs kzip info... for additional verification of adherence to the spec. Howeer, that last test is currently not enabled as it is apparently not allowed to subprocess to a binary.
shahms
reviewed
Aug 13, 2020
The integration test had a wrong path to the binary. When corrected, all is well now.
shahms
approved these changes
Aug 13, 2020
|
Thanks! F |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code filled FileInfo.path with a path relative to the corpus
root, but should instead have filled it with a path relative to the
build directory.
Added a regression tests, and added most of an integration test
which runs kzip info... for additional verification of adherence
to the spec.
Howeer, that last test is currently not enabled as it is apparently
not allowed to subprocess to a binary.