Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image size errors in slider #4

Closed
KyubiSystems opened this issue Aug 31, 2014 · 1 comment
Closed

Image size errors in slider #4

KyubiSystems opened this issue Aug 31, 2014 · 1 comment
Assignees
@KyubiSystems
Labels
bug

Comments

@KyubiSystems
Copy link
Owner

Image N+1 in slider inherits size of image N, so banner results in all subsequent images having wrong aspect ratio. Need to set image size explicitly - scale image to viewport preserving aspect ratio?
@KyubiSystems KyubiSystems self-assigned this Aug 31, 2014
@KyubiSystems
Copy link
Owner Author

Hacked around this a bit with CSS image sizes in 7aa0e8d. Will probably need to do CSS media queries etc. to do a better job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KyubiSystems KyubiSystems

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KyubiSystems