-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add error check in jmespath type conversion in context variables #10152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
vishal-chdhry
requested review from
chipzoller,
eddycharly,
realshuting,
MariamFahmy98,
KhaledEmaraDev and
MarcelMue
as code owners
May 1, 2024 02:48
vishal-chdhry
force-pushed
the
panic-fix-jp-variable
branch
2 times, most recently
from
May 1, 2024 02:52
6f32bcf
to
c075757
Compare
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10152 +/- ##
==========================================
- Coverage 10.15% 10.15% -0.01%
==========================================
Files 1030 1030
Lines 91779 91782 +3
==========================================
Hits 9323 9323
- Misses 81438 81441 +3
Partials 1018 1018 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
vishal-chdhry
force-pushed
the
panic-fix-jp-variable
branch
from
May 1, 2024 03:25
d948304
to
abe054f
Compare
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
realshuting
previously approved these changes
May 1, 2024
/cherry-pick release-1.12 |
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
realshuting
approved these changes
May 1, 2024
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 1, 2024
…#10152) * fix: add error check in jmespath type conversion in context variables Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix(lint): new line in tests Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: properly update path variable Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: remove log statemet Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
realshuting
added
the
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
label
May 1, 2024
realshuting
pushed a commit
that referenced
this pull request
May 1, 2024
anushkamittal2001
pushed a commit
to nirmata/kyverno
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
cherry-pick-required
milestone 1.12.1
milestone 1.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The following policy and pod caused panic in admission and reports-controller
Apply the following pod
This is because the path variable resolves to empty value and its type conversion caused a panic, this PR makes that type conversion safer.
Related issue
NA
Milestone of this PR
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
Proposed Changes
Proof Manifests
Checklist
Further Comments