fix: add error check in jmespath type conversion in context variables (cherry-pick #10152) #10153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…#10152) * fix: add error check in jmespath type conversion in context variables Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix(lint): new line in tests Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: properly update path variable Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: remove log statemet Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
gcp-cherry-pick-bot
bot
requested review from
chipzoller,
eddycharly,
realshuting,
MariamFahmy98 and
MarcelMue
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #10153 +/- ##
=============================================
Coverage 33.67% 33.67%
=============================================
Files 347 347
Lines 23904 23904
=============================================
Hits 8049 8049
Misses 14971 14971
Partials 884 884 ☔ View full report in Codecov by Sentry. |
realshuting
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: add error check in jmespath type conversion in context variables (#10152)
Signed-off-by: Vishal Choudhary vishal.choudhary@nirmata.com
Signed-off-by: Vishal Choudhary vishal.choudhary@nirmata.com
Signed-off-by: Vishal Choudhary vishal.choudhary@nirmata.com
Signed-off-by: Vishal Choudhary vishal.choudhary@nirmata.com
Signed-off-by: Vishal Choudhary vishal.choudhary@nirmata.com