Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HTTP(git raw or any public url ) URL applying functionality to kyverno cli #1527

Merged
merged 4 commits into from
Feb 6, 2021

Conversation

imrajdas
Copy link
Contributor

@imrajdas imrajdas commented Feb 2, 2021

Related issue

Closes- #1422

Changes

  • pkg/kyverno/common/common.go, pkg/kyverno/common/fetch.go
    Adding additonal logic to read http files and local files
  • Any combination of file type can be applied by the kyverno cli
    • kyverno apply policy.yaml -r http://url/resource.yaml
    • kyverno apply http://url.com/policy.yaml -r http://url.com/resource.yaml
    • kyverno apply ./deploy/policy.yaml -r http://url.com/resource.yaml
  • Both apply and validatecommand support this feature

Screenshot
Selection_135

What type of PR is this?

Proposed changes

Checklist

Further comments

Signed-off-by: Raj Das <mail.rajdas@gmail.com>
Signed-off-by: Raj Das <mail.rajdas@gmail.com>
@imrajdas
Copy link
Contributor Author

imrajdas commented Feb 2, 2021

@JimBugwadia / @realshuting / @chipzoller PTAL

@imrajdas
Copy link
Contributor Author

imrajdas commented Feb 2, 2021

/kind feature

Signed-off-by: Raj Das <mail.rajdas@gmail.com>
Signed-off-by: Raj Das <mail.rajdas@gmail.com>
@realshuting
Copy link
Member

@vyankyGH I saw the issue was assigned to you, have you started yet?

Can you collaborate with @rajdas98 to get this done?

@realshuting realshuting merged commit 0487330 into kyverno:main Feb 6, 2021
realshuting added a commit that referenced this pull request Feb 6, 2021
realshuting added a commit to realshuting/kyverno that referenced this pull request Feb 6, 2021
…ality to kyverno cli (kyverno#1527)"

This reverts commit 0487330.

Signed-off-by: Shuting Zhao <shutting06@gmail.com>
realshuting added a commit that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants