Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adding HTTP(git raw or any public url ) URL applying functionality to kyverno cli" #1548

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

realshuting
Copy link
Member

Reverts #1527

@imrajdas
Copy link
Contributor

imrajdas commented Feb 6, 2021

@realshuting Locally, it is building properly. Can you rerun the pipeline?

@imrajdas
Copy link
Contributor

imrajdas commented Feb 6, 2021

Logs- log.txt

@realshuting
Copy link
Member Author

It was failing for me,

The command '/bin/sh -c CGO_ENABLED=0 GOOS=linux go build -o /output/kyverno -ldflags="${LD_FLAGS}" -v ./cmd/kyverno/' returned a non-zero code: 2
make: *** [docker-build-kyverno] Error 2

Then I reverted to the previous make docker-build-kyverno, then I saw:

# github.com/kyverno/kyverno/pkg/kyverno/common
pkg/kyverno/common/common.go:14:2: strings redeclared as imported package name
	previous declaration at pkg/kyverno/common/common.go:12:2
make: *** [docker-build-kyverno] Error 2

make kyverno:

# github.com/kyverno/kyverno/pkg/kyverno/common
pkg/kyverno/common/common.go:96:16: result of fmt.Errorf call not used
pkg/kyverno/common/common.go:107:16: result of fmt.Errorf call not used
# github.com/kyverno/kyverno/pkg/kyverno/test
pkg/kyverno/test/command.go:302:3: unreachable code
make: *** [vet] Error 2

@realshuting
Copy link
Member Author

@rajdas98
I'm going to merge this PR to get pending PR merged. Can you please fix the above issue and re-send the PR? Thanks!

@imrajdas
Copy link
Contributor

imrajdas commented Feb 6, 2021

sure @realshuting

@realshuting realshuting merged commit c42d545 into main Feb 6, 2021
@realshuting realshuting deleted the revert-1527-git-path branch February 6, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants