Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Namespace scope when extracting raw from the admission request #1718

Merged
merged 1 commit into from Mar 17, 2021
Merged

Fix Namespace scope when extracting raw from the admission request #1718

merged 1 commit into from Mar 17, 2021

Conversation

realshuting
Copy link
Member

@realshuting realshuting commented Mar 17, 2021 •
edited

Signed-off-by: Shuting Zhao shutting06@gmail.com

Related issue

Fixes #1437.

What type of PR is this

/kind bug

Proposed changes

While investigating 1437, I noticed that request.Namespace is set for kind Namespace, thus it results in incorrect policy reports (for Namespace kind only). This PR fixes the scope of the type Namespace.

Checklist

Further comments

@realshuting
fix Namespace scope
0ce1a80 
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
@realshuting realshuting changed the title Fix Namespace scope when extracting from the admission request Fix Namespace scope when extracting raw from the admission request Mar 17, 2021
@realshuting realshuting mentioned this pull request Mar 17, 2021
Closed
@realshuting realshuting merged commit 9a99cc3 into kyverno:main Mar 17, 2021
@realshuting realshuting deleted the 1437_fix_cpolr branch March 17, 2021 19:19
This was referenced Mar 18, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyankyGH vyankyGH vyankyGH approved these changes

Assignees

@vyankyGH vyankyGH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] deleting namespace create cluster policy report
2 participants
@realshuting @vyankyGH