allow only supplementalGroups greater 0 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnmtzgr
force-pushed
the
update-supplementalGroups-value
branch
from
aeea347
to
f6bba0f
Compare
realshuting
approved these changes
May 10, 2021
|
If the minimum version of Kyverno needed to support this is 1.3.6, we need to add the relevant annotation as seen here. This also needs to be held until 1.3.6 releases. |
|
@chipzoller should I add this annotation? |
|
Yes, let's go ahead and add this annotation now that 1.3.6 is released. |
smnmtzgr
force-pushed
the
update-supplementalGroups-value
branch
from
f6bba0f
to
0d48a8e
Compare
|
@chipzoller / @realshuting I have added the annotation. Can you check it again and if okay please merge. |
Signed-off-by: Metzger, Simon <smnmtzgr@gmail.com>
smnmtzgr
force-pushed
the
update-supplementalGroups-value
branch
from
0d48a8e
to
3db84ed
Compare
realshuting
requested changes
May 21, 2021
| @@ -5,6 +5,7 @@ metadata: | |||
| annotations: | |||
| policies.kyverno.io/category: Pod Security Standards (Restricted) | |||
| policies.kyverno.io/severity: medium | |||
| policies.kyverno.io/minversion: 1.6.0 | |||
There was a problem hiding this comment.
Hi @smnmtzgr - the minimum version should be 1.3.6.
Signed-off-by: Metzger, Simon <smnmtzgr@gmail.com>
smnmtzgr
force-pushed
the
update-supplementalGroups-value
branch
from
853d416
to
5b6fd7c
Compare
realshuting
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.