Enable builtin metrics and add default ServiceMonitor #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the ServiceMonitor CRD doesn't actually exist in e2e tests. Happy to proceed however the maintainers like |
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
…yverno#119) Signed-off-by: Mike Dougherty <mike.dougherty@missionlane.com> Co-authored-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
|
I realized that the main |
|
The codecov failure is due to rate limiting, which I think is unrelated to these changes |
vishal-chdhry
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #118
Enables the default unauthenticated endpoint for scraping the built-in apiserver and go metrics. Also adds a ServiceMonitor to have the metrics scraped by Prometheus.