Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[todo] Use ServiceLocator DI to store use cases for the view models #73

Closed
kyzmitch opened this issue Jan 22, 2024 · 0 comments
Closed

[todo] Use ServiceLocator DI to store use cases for the view models #73

kyzmitch opened this issue Jan 22, 2024 · 0 comments
Labels
enhancement iOS iOS client sources

Comments

@kyzmitch
Copy link
Owner

kyzmitch commented Jan 22, 2024 •
edited
Loading

Some existing classes has a lot of dependencies e.g. BrowserContentView, need to leverage service locator pattern or implement DI.
In the new PR #72 which is not finished yet I had to create service locator to access the use cases, but need to improve it even more.

Make sure to use ServiceLocator only inside UseCaseFactory or other factories.
@kyzmitch kyzmitch added enhancement iOS iOS client sources labels Jan 22, 2024
@kyzmitch kyzmitch changed the title [todo] Use ServiceLocator or implement own small DI infrastructure [todo] Use ServiceLocator DI to store use cases for the view models Jan 31, 2024
@kyzmitch kyzmitch closed this as completed Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement iOS iOS client sources
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyzmitch