Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in code CasListener.php #4

Closed
t0mab opened this issue May 10, 2017 · 6 comments
Closed

Typo in code CasListener.php #4

t0mab opened this issue May 10, 2017 · 6 comments

Comments

@t0mab
Copy link

t0mab commented May 10, 2017

Sorry no time for forking / pull request, a colleague asked me to debug a problem in his code using your bundle I think therse is a typo in CasBundle/Security/CasListener.php

line 29 :
\phpCas::client(CAS_VERSION_2_0, $this->getParameter('host'),
$this->getParameter('port'), is_null($this->getParameter('path')) ? '' :
$this->getParameter('path'), true);

should be :

\phpCAS::client(CAS_VERSION_2_0, $this->getParameter('host'),
$this->getParameter('port'), is_null($this->getParameter('path')) ? '' :
$this->getParameter('path'), true);

am I wrong ?

@mhetru
Copy link
Collaborator

mhetru commented May 10, 2017

Hello,
okay.
and for which version symfony is your request?

@t0mab
Copy link
Author

t0mab commented May 11, 2017

Hi my colleague is using symfony 3

@mhetru
Copy link
Collaborator

mhetru commented May 13, 2017

Ok i will do the correction

@mhetru
Copy link
Collaborator

mhetru commented May 14, 2017

done, can you test?

@mhetru
Copy link
Collaborator

mhetru commented May 17, 2017

is it ok for you?

@t0mab
Copy link
Author

t0mab commented May 17, 2017

Fixed & working !

@t0mab t0mab closed this as completed May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants