Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when trying to review #16

Closed
ram535 opened this issue Mar 20, 2020 · 5 comments
Closed

Error when trying to review #16

ram535 opened this issue Mar 20, 2020 · 5 comments

Comments

@ram535
Copy link

ram535 commented Mar 20, 2020

This is my first time trying org-fc.
I am using Emacs 28.0.5 and org mode version 9.3.6.

This is how I install it.

(use-package org-fc
  :straight (org-fc :type git :host github :repo "l3kn/org-fc")
  :custom
  (org-fc-directories '("~/org/drills"))
  :config
  (require 'org-fc-hydra))

When running org-fc-review-all, it outputs this message in the
echo area Invalid Function assert.

When running org-fc-dashboard, it outputs this message in the
echo area Wrong type argument: stringp, nil.

This commands work fine:

org-fc-type-normal-init
org-fc-type-text-input-init
org-fc-type-double-init
org-fc-type-cloze-init
@l3kn
Copy link
Owner

l3kn commented Mar 22, 2020

I've merged a pull request that should take care of the Invalid Function assert problem.
Not sure about the Wrong type argument: stringp, nil one.

Can you check if the folder the package was installed to contains anawk/ folder with scripts in it?
You can also try M-x toggle-debug-on-error then running org-fc-dashboard again,
to get more information on where the error happens.

@ram535
Copy link
Author

ram535 commented Mar 26, 2020

After updating, I got this error:

Error (use-package): org-fc/:config: Cannot open load file: No such file or directory, org-fc-review

I removed (require 'org-fc-review) and error was solved.
I do not remember why was that in my configuration.

I think where the error might come from.
straight download the repo in ~/.emacs.d/straight/repos/org-fc.

  drwxrwxr-x awk
  drwxrwxr-x doc
  drwxrwxr-x images
  -rw-rw-r-- LICENSE
  -rw-rw-r-- README.org
  -rw-rw-r-- demo.org
  -rw-rw-r-- org-fc.el
  -rw-rw-r-- org-fc-hydra.el

And then it compile the repo to ~/.emacs.d/straight/build/org-fc.
Which the version that tries to load to emacs.
I might be completely wrong and I might don't understand how everything works.

-rw-rw-r-- org-fc-autoloads.el
lrwxrwxrwx org-fc.el -> ~/.emacs.d/straight/repos/org-fc/org-fc.el
-rw-rw-r-- org-fc.elc
lrwxrwxrwx org-fc-hydra.el -> ~/.emacs.d/straight/repos/org-fc/org-fc-hydra.el
-rw-rw-r-- org-fc-hydra.elc

Now when running org-fc-dashboard, I get this error Assertion failed: (not(null elements)).

If I load org-fc, the classic way, everything works fine.

(add-to-list 'load-path "~/.emacs.d/straight/repos/org-fc")

(require 'org-fc-hydra)

@ram535 ram535 closed this as completed Mar 26, 2020
@l3kn
Copy link
Owner

l3kn commented Mar 26, 2020

Thanks for your investigation!

I've pushed a change that follows symlinks when determining the path to the awk source files,
can you check if this works with your straight installation method?

You might have to restart Emacs to make sure the variable gets redefined.

Let me know if that works, then I can include the use-package + straight installation method in the readme.

@l3kn l3kn reopened this Mar 26, 2020
@ram535
Copy link
Author

ram535 commented Mar 26, 2020

It works :)

@l3kn
Copy link
Owner

l3kn commented Mar 27, 2020

Great, I've included the use-package + straight example in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants