Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Add support to decode .ogg music files #222

Open
richardscull opened this issue Nov 17, 2023 · 0 comments
Open

Proposal: Add support to decode .ogg music files #222

richardscull opened this issue Nov 17, 2023 · 0 comments

Comments

@richardscull
Copy link

So in stable version if you try to run any osu! Song with music extension which is not .mp3 it will give you an error: "Expected mp3, got something else. Aborting mp3 time calculation. GOT: "song.ogg""

Some old maps use .ogg music files, like this one.
Also, I should mention that .ogg files are approved as ranking criteria: ppy/osu-wiki#3686, so there is a high chance to have this error occurring.

My proposal is to add support of decoding .ogg files too in calculateMP3Time function (Could be renamed to calculateMusicTime then).
@richardscull richardscull changed the title The program can't handle other audio extensions except .mp3 Proposal: Add support to decode .ogg music files Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richardscull