-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Allow ability to upload/set logo for dashboard inventory view #27
Comments
The idea is nice. Following issues will occur:
I could provide some fixed background images for often used stores like Amazon, Steam etc. However, this will not introduce the flexibility you desire and requires maintenance (as many users will request more stores do be added). Will have to think about this one and play around. ExamplesA random Amazon logo would currently look like this: |
Guessed right. There is a cool API on https://www.logo.dev/:
User can just submit a logo url and that's it. Maybe use some JS to obtain the logo's primary color and colorize the full tile in alike color. |
It's your program, however having something predefined and not user uploaded is going to end up just being an all-round pain for you and the users who want some flexibility... there are going to be 10's of thousands of businesses not within any of those predefined logo spaces. You'll end up with a bunch of requests or end up just opening it up, being sick of people asking for X company logo Is it possible to have guidelines for an appropriately sized image? I see the update regarding the app icon in the corner over the barcode and once again, its yours program but I don't necessarily enjoy that concept from a visual perspective (i understand it's all subjective) One other work around could be a 'compact' view for your dashboard sub category inventory view... |
I've created a new branch to play around with this. https://github.com/l4rm4nd/VoucherVault/tree/feature-logos Currently, the flexible logos via logo.clearbit.com is implemented. Works as intended by providing the user a chance to define a logo slug. |
Nice work. |
Pushed a new release (v1.5.0) with the ability to define store logos. See #28 Also overhauled the dashboard a bit. |
Will close this issue for now as not planned. Will still play around though whether custom background images are somehow possible. |
Within the
dashboardinventory view it would be nice to have the primary view be a logo type setup with some of the details still visible with the expiry's (if a gift card) being able to be shown if the item differs from a gift card to a loyalty card.Proposed I guess is something similar to catima but not quite... which has a card view but this method allows you to easily pick the card based on the logo/brand that you can upload the image as well a differentiate if its a loyalty card/gift card....
Catima's is quite small and would not allow you to differentiate between gift cards, loyalty cards, etc easily.
I like the way your inventory dashboard is displayed in mobile.
If you were able to have the background of the card have a logo picture, then have the details overlayed it would assist at a glance at just the dash board in determining what you are looking at using...
With gift cards, an issue/expiry date is shown.
For loyalty cards, no issue/expiry date is shown
I have included a couple example mock ups base on your current mobile view.
The text was updated successfully, but these errors were encountered: